Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create ACTIVITYTYPES.md #2228

Merged
merged 10 commits into from
Jul 31, 2019
Merged

Create ACTIVITYTYPES.md #2228

merged 10 commits into from
Jul 31, 2019

Conversation

corinagum
Copy link
Contributor

Fixes #1808

Description

Adding documentation on Activity Types rendered by Web Chat.

Specific Changes

  • Testing Added

@coveralls
Copy link

coveralls commented Jul 26, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 64.984% when pulling 3319ed1 on docs-1808 into 30b6856 on master.

compulim
compulim reviewed Jul 26, 2019
View reviewed changes
Copy link
Contributor

@compulim compulim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The doc looks a bit rough.

I think most devs do not understand the network relationship between "client <-> channel <-> bot". And channel sometimes create activities that is only sent to one side of the party.

ACTIVITYTYPES.md Outdated Show resolved Hide resolved
ACTIVITYTYPES.md Outdated Show resolved Hide resolved
ACTIVITYTYPES.md Outdated Show resolved Hide resolved
ACTIVITYTYPES.md Outdated Show resolved Hide resolved
ACTIVITYTYPES.md Outdated Show resolved Hide resolved
ACTIVITYTYPES.md Outdated Show resolved Hide resolved
ACTIVITYTYPES.md Outdated Show resolved Hide resolved
@corinagum corinagum requested a review from compulim July 27, 2019 21:03
compulim
compulim approved these changes Jul 30, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
ACTIVITYTYPES.md Outdated Show resolved Hide resolved
ACTIVITYTYPES.md Outdated Show resolved Hide resolved
ACTIVITYTYPES.md Show resolved Hide resolved
ACTIVITYTYPES.md Outdated Show resolved Hide resolved
@corinagum corinagum merged commit 5dc8e43 into master Jul 31, 2019
@corinagum corinagum deleted the docs-1808 branch August 5, 2019 19:16
@compulim compulim mentioned this pull request Oct 25, 2019
Closed
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compulim compulim compulim approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@corinagum @coveralls @compulim